Description

Remove GUIDS and instead use an Azure data reader instead.

Quite a simple PR here; simply revert the functionality back to the state it was previously. Please note the lower environments, review, dev and preprod had this reader already working but Prod did not. There was a change implemented by the NHS infrastructure team which allowed the data reader to be used for the Prod environment. The duration taken for the permission to be granted was long enough to put a temporary fix in (to avoid having a feature branch in a production), i.e. read the GUIDs as an environment variable. However, the prod data reader has now been implemented. So this change reverts it back to its original state.

The following command confirms it works in prod:-

(manage-breast-screening-gateway) alastairlock@Alastairs-MacBook-Pro manage-breast-screening-gateway % az ad group list \
  --display-name "screening_mbsgw_prod" \ 
  --query '[].{displayName:displayName, objectId:id}' \
  --output table
DisplayName           ObjectId
--------------------  ------------------------------------
screening_mbsgw_prod  3**************************98a
(manage-breast-screening-gateway) alastairlock@Alastairs-MacBook-Pro manage-breast-screening-gateway % 

(manage-breast-screening-gateway) alastairlock@Alastairs-MacBook-Pro manage-breast-screening-gateway %

Jira link

https://nhsd-jira.digital.nhs.uk/browse/DTOSS-13497

Review notes

This evidences that it working below: -

https://dev.azure.com/nhse-dtos/manage-breast-screening-gateway/_build/results?buildId=42010&view=logs&j=65766a98-ecd4-5f91-c74b-4b239522f3e3&t=3d41361f-22ab-5a54-7607-415e06b0074d

Note this is on the review environment.

Review checklist

• Check database queries are correctly scoped to current_provider